I've owned a KeepCup for about a year and though I clean it after use it really is starting to stink.
I've tried scrubbing it with a scouring pad and detergent and leaving it to soak overnight, but it still smells bad.
The cup looks like the one below. All pieces can be disassembled to make cleaning easy. It's like the smell is in the plastic it's self.